Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fields that should be final, as reported by SpotBugs #1268

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Fix fields that should be final, as reported by SpotBugs #1268

merged 1 commit into from
Feb 11, 2019

Conversation

tomwhite
Copy link
Contributor

Description

Fixes some of the issues reported in #1267

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)

@codecov-io
Copy link

codecov-io commented Jan 28, 2019 •
edited
Loading

Codecov Report

Merging #1268 into master will increase coverage by 0.002%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##              master    #1268       +/-   ##
==============================================
+ Coverage     69.358%   69.36%   +0.002%     
+ Complexity      8302     8298        -4     
==============================================
  Files            555      555               
  Lines          33118    33114        -4     
  Branches        5572     5572               
==============================================
- Hits           22970    22968        -2     
+ Misses          7886     7884        -2     
  Partials        2262     2262
Impacted Files Coverage Δ Complexity Δ
...k/tribble/index/interval/IntervalIndexCreator.java 88.679% <ø> (-0.21%) 14 <0> (-1)
src/main/java/htsjdk/samtools/util/TestUtil.java 48% <ø> (-2%) 2 <0> (-1)
.../main/java/htsjdk/samtools/util/ftp/FTPClient.java 23.171% <ø> (-0.926%) 6 <0> (-1)
...tsjdk/tribble/index/linear/LinearIndexCreator.java 83.333% <ø> (-0.388%) 14 <0> (-1)
src/main/java/htsjdk/samtools/cram/CRAIEntry.java 71.053% <100%> (ø) 17 <0> (ø) ⬇️
...mtools/reference/ReferenceSequenceFileFactory.java 78.723% <100%> (ø) 22 <1> (ø) ⬇️
...rc/main/java/htsjdk/samtools/SamReaderFactory.java 67.464% <100%> (ø) 7 <0> (ø) ⬇️
src/main/java/htsjdk/samtools/SAMRecord.java 67.271% <100%> (ø) 300 <0> (ø) ⬇️
...rc/main/java/htsjdk/tribble/util/ParsingUtils.java 73.684% <100%> (ø) 45 <1> (ø) ⬇️
...n/java/htsjdk/tribble/index/tabix/TabixFormat.java 54.286% <100%> (ø) 6 <1> (ø) ⬇️
... and 2 more

lbergelson
lbergelson approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomwhite Looks good, thank you.

@lbergelson lbergelson merged commit 77b3b8f into samtools:master Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbergelson lbergelson lbergelson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomwhite @codecov-io @lbergelson